-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): flush upon a single metric 100th data point #1046
fix(metrics): flush upon a single metric 100th data point #1046
Conversation
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
cc @pankajagrawal16 @saragerion @flochaz - this is the bug we discussed on metric data points having a maximum of 100. |
@jaredcnance thanks again for confirming this in the spec. Next release will have this fix on Lambda Powertools for Python. and thank you very much @jonemo for spotting as well as fixing it. I didn't create an issue because it's in the Spec we missed |
@heitorlessa Since Powertools for Java internally uses https://github.com/awslabs/aws-embedded-metrics-java, this is fixed already in the lib as part of this issue via this PR. Let me know if I am missing something still that was fixed as part of this change. As far as I can see, Powertools for Java is covered. |
@heitorlessa thanks for flagging this (@saragerion reached out to me).
I've opened an issue on TypeScript's side to track the effort to EDIT: we don't use the EMF library so we might need to implement it |
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
Description of changes:
Issue: #1062
Per the EMF spec, metric value arrays must not have more than 100 elements. This PR ensures that metrics are serialized when a single metric collects 100 values in addition to the existing behavior of serializing when 100 metrics are collected.
Note: as far as I can see, this same change needs to be brought to the other Powertools languages as well. I'm not equipped nor have the skill to submit a PR for any language other than Python.
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.