fix(data-classes): fix SES date field typing and add missing fields
#1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - Fix date type to be a str and not List[str] - Add missing fields from SESMailCommonHeaders (bcc, cc, sender and replyTo) - Add missing dkimVerdict field - Add missing dmarcPolicy field - Add missing topicArn field - Add missing docs for SESReceiptStatus status field related aws-powertools#1025
pull-request-size
bot
added
the
size/M
Codecov Report
@@ Coverage Diff @@
## develop #1045 +/- ##
========================================
Coverage 99.96% 99.96%
========================================
Files 119 119
Lines 5378 5399 +21
Branches 613 613
========================================
+ Hits 5376 5397 +21
Partials 2 2
Continue to review full report at Codecov.
|
michaelbrewer
changed the title
michaelbrewer
changed the title
date field fix typing
added 5 commits
March 9, 2022 09:44
michaelbrewer
changed the title
date field fix typingdate field typing and add missing fields
added 9 commits
April 5, 2022 10:06
|
As far as I can see, the fields are correct with what's in the event at generation time |
heitorlessa
added a commit
to ran-isenberg/aws-lambda-powertools-python
that referenced
this pull request
May 18, 2022
* develop: (33 commits) fix(docs): remove Slack link (aws-powertools#1210) docs(roadmap): add new roadmap section (aws-powertools#1204) fix(batch): missing space in BatchProcessingError message (aws-powertools#1201) fix(batch): docstring fix for success_handler() record parameter (aws-powertools#1202) chore(deps): bump email-validator from 1.1.3 to 1.2.1 (aws-powertools#1199) docs(layer): upgrade to 1.25.10 chore: include regression in changelog chore: bump to 1.25.10 feat(parameters): add clear_cache method for providers (aws-powertools#1194) chore(ci): changelog pre-generation to fetch tags from origin revert(parser): Add missing fields for SESEvent (aws-powertools#1027) (aws-powertools#1190) fix(parser): Add missing fields for SESEvent (aws-powertools#1027) fix(data-classes): Add missing SES fields and (aws-powertools#1045) fix(event_handler): exception_handler to handle ServiceError exceptions (aws-powertools#1160) chore(deps-dev): bump flake8-bugbear from 22.1.11 to 22.4.25 (aws-powertools#1156) chore(deps-dev): bump mypy from 0.942 to 0.950 (aws-powertools#1162) chore(deps-dev): bump flake8-eradicate from 1.2.0 to 1.2.1 (aws-powertools#1158) chore(deps): bump github/codeql-action from 1 to 2 (aws-powertools#1154) chore(ci): post release on tagged issues too fix(event_handler): Allow for event_source support (aws-powertools#1159) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
datefield typing and add missing fields #1025Description of changes:
Changes:
datetyping to be astrand notList[str]SESMailCommonHeaders(bcc,cc,senderandreplyTo)dkimVerdictfielddmarcPolicyfieldtopicArnfieldSESReceiptStatusstatus fieldChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.