Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Enhanced Targetting via Tags #688

Open
1 task done
alexevansigg opened this issue Feb 16, 2024 · 1 comment
Open
1 task done

[Feat]: Enhanced Targetting via Tags #688

alexevansigg opened this issue Feb 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@alexevansigg
Copy link
Contributor

Describe the feature

Deployment Maps Targeting via Tags improvement.
When targeting via tags, I want to target multiple values for the same tag without needing multiple stages and also target via multiple named tags in the same stage

Use Case

All my accounts are tagged with the a key "account-short-name" the value is a short unique name within the organization for the account.

I want to target several such accounts to deploy the same stack too.

Proposed Solution

Add support for List in Tag values such as ...

tags:
   account-short-name:
       - my-account-tag-1
       - my-account-tag-2

Additionally add a conditional operator support for multiple named tags

tags-condition: any # Filter accounts matching either of the below tags.
tags:
   account-short-name: my-test-account-tag-1
   environment: dev
tags-condition: all # Filter accounts which match both of the below tags.
tags:
   account-short-name: my-test-account-tag-1
   environment: dev

Acknowledgements

  • I may be able to implement this feature request
@sbkok
Copy link
Collaborator

sbkok commented Mar 26, 2024

That would be a great improvement, thanks for suggesting this and offering to build the feature!

If you could draft the required changes for the schema_validation.py to start with, that would ease the discussion on how this would work.

Ideally this would be backwards compatible with the current implementation.
I'm happy to discuss and assist with reviews of your implementation.

@sbkok sbkok added the enhancement New feature or request label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants