Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improvements to tox and Makefile due to issue on MacOS #473

Closed
javydekoning opened this issue May 23, 2022 · 0 comments
Closed

feat: Improvements to tox and Makefile due to issue on MacOS #473

javydekoning opened this issue May 23, 2022 · 0 comments
Milestone

Comments

@javydekoning
Copy link
Contributor

I'm running into this issue on my Mac:

https://apple.stackexchange.com/questions/249313/mac-terminal-find-command-what-does-a-double-slash-in-the-result-output-mean

The problem is the find command isn't excluding the .aws-sam/ directory.

find src/ -iname "*.py" -not -path "src/.aws-sam/*"
...
src//.aws-sam/build/OrganizationHandler/handler.py
src//.aws-sam/build/OrganizationHandler/cfn_custom_resource/decorator.py
src//.aws-sam/build/OrganizationHandler/cfn_custom_resource/__init__.py
src//.aws-sam/build/OrganizationHandler/main.py

This can easily be fixed by removing the trailing slash.

find src -iname "*.py" -not -path "src/.aws-sam/*"
src/lambda_codebase/organization/handler.py
src/lambda_codebase/organization/main.py
src/lambda_codebase/event.py
src/lambda_codebase/account_bootstrap.py
src/lambda_codebase/generic_account_config.py
src/lambda_codebase/account_processing/configure_account_ou.py
src/lambda_codebase/account_processing/tests/test_account_creation.py
src/lambda_codebase/account_processing/tests/__init__.py

I'd also like to include the cfn-lint and yamllint execution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants