Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic GovCloud Support #332

Closed
dsudduth opened this issue Feb 19, 2021 · 4 comments · Fixed by #381
Closed

Basic GovCloud Support #332

dsudduth opened this issue Feb 19, 2021 · 4 comments · Fixed by #381
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@dsudduth
Copy link
Contributor

dsudduth commented Feb 19, 2021

GovCloud Support

Summary

This feature request would provide basic support for GovCloud regions by adjusting partitions throughout templates and the code base to leverage the ${AWS::Partition} pseudo parameter. It would also add conditional statements for services that do not exist in GovCloud. i.e., Tagging Policies.

Motivation

GovCloud customers are looking for a robust CI/CD framework based on AWS native tooling. ADF is one of the most feature rich options. With small changes this framework could easily be adapted to support a wider audience.

In Scope

  • Modify the code base to support the arn:aws-us-gov GovCloud partition.
  • Provide support for the us-gov-west-1 region as a primary install location.
  • Avoid failures due to missing features in GovCloud. The only item identified in the code base is Tagging Policies.

Out of Scope

Account Vending in GovCloud - Account vending in GovCloud requires accounts to be created in commercial regions and linked. The changes needed to support this would be significant and will not be addressed by this feature.

References

@sbkok
Copy link
Collaborator

sbkok commented Feb 19, 2021

Thanks for submitting this request @dsudduth!
I'm looking into the required steps and will reach out to you directly to sync up.

@sbkok sbkok self-assigned this Feb 19, 2021
@OlafConijn
Copy link

interesting! we are currently building govcloud support in org-formation (https://github.com/org-formation/org-formation-cli). if you find it interesting feel free to ping me and we can compare noted. easiest way to do so is over the org-formation slack (https://join.slack.com/t/org-formation/shared_invite/enQtOTA5NjM3Mzc4ODUwLTMxZjYxYzljZTE5YWUzODE2MTNmYjM5NTY5Nzc3MzljNjVlZGQ1ODEzZDgyMWVkMDg3Mzk1ZjQ1ZjM4MDhlOGM).

@dsudduth
Copy link
Contributor Author

Hi @OlafConijn! Thanks for sharing your tool. Looks great! I'll connect with you on Slack. Any tool that can work across commercial and GovCloud is of interest.

@sbkok sbkok linked a pull request Nov 8, 2021 that will close this issue
@sbkok sbkok added this to the v3.2.0 milestone Nov 8, 2021
@sbkok sbkok added the enhancement New feature or request label Nov 8, 2021
@sbkok
Copy link
Collaborator

sbkok commented Jan 24, 2023

Thank you for your patience. I am happy to inform you that this feature has been released as part of v3.2.0 just now.
I'm hereby closing this issue. Please open a new issue if you are experiencing any issues related to this feature.

@sbkok sbkok closed this as completed Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants