Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make capitalization of abbrevations consistent #3202

Merged
merged 4 commits into from
Jul 5, 2019

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jul 4, 2019

Fix short miscapitalizations of an abbreviation with a lowercase suffix;
they would not get properly translated into Python.

BREAKING CHANGE: in all identifiers, renamed IPv4 => Ipv4, IPv6 =>
Ipv6, AZs => Azs.


Please read the contribution guidelines and follow the pull-request checklist.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fix short miscapitalizations of an abbreviation with a lowercase suffix;
they would not get properly translated into Python.

BREAKING CHANGE: in all identifiers, renamed `IPv4` => `Ipv4`, `IPv6` =>
`Ipv6`, `AZs` => `Azs`.
@rix0rrr rix0rrr requested review from RomainMuller, skinny85, SoManyHs and a team as code owners July 4, 2019 13:49
@rix0rrr rix0rrr merged commit d60d673 into master Jul 5, 2019
@rix0rrr rix0rrr deleted the huijbers/fix-capitalizations branch July 5, 2019 10:57
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants