Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename all enum-like members to all-caps (same as normal enums) #3018

Closed
eladb opened this issue Jun 23, 2019 · 0 comments · Fixed by #3023
Closed

Rename all enum-like members to all-caps (same as normal enums) #3018

eladb opened this issue Jun 23, 2019 · 0 comments · Fixed by #3023

Comments

@eladb
Copy link
Contributor

eladb commented Jun 23, 2019

No description provided.

shivlaks added a commit that referenced this issue Jun 24, 2019
@shivlaks
refactor: rename enum-like members to ALL_CAPS
42b29ef 
Similar to the enum naming convention, public static readonly properties
must be ALL_CAPS.

This is in accordance with the new construct library guidelines.

Fixes #3018

BREAKING CHANGE: members in enum like classes are now named using ALL_CAPS
@shivlaks shivlaks mentioned this issue Jun 24, 2019
Merged
eladb pushed a commit that referenced this issue Jun 24, 2019
@shivlaks
refactor: rename enum-like members to ALL_CAPS (#3023)
9d19aef 
Similar to the enum naming convention, public static readonly properties
must be ALL_CAPS.

This is in accordance with the new construct library guidelines and with normal enums.

Fixes #3018
Fixes #980

BREAKING CHANGE: all public static readonly members (enum-like) have been renamed to use "ALL_CAPS" capitalization
@mhuebner mhuebner mentioned this issue Jun 26, 2019
Closed
1 task
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
This was referenced Sep 24, 2024
Open
Open
Open
This was referenced Sep 24, 2024
Open
Open
Open
Open
Open
Open
Open
Open
@NOUIY NOUIY mentioned this issue Oct 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename enum-like members to ALL_CAPS aws/aws-cdk
2 participants
@eladb @shivlaks