Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pkglint): Adjust stability banner style #2768

Merged
merged 2 commits into from
Jun 6, 2019

Conversation

RomainMuller
Copy link
Contributor

GitHub markdown does not allow use of inline CSS on <div> elements,
resulting in a poor looking README.md experience on the website.
Adjusted the style to use a blockquote in order to have the stability
indication stand out more, while being visually pleasant.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

GitHub markdown does not allow use of inline CSS on `<div>` elements,
resulting in a poor looking `README.md` experience on the website.
Adjusted the style to use a blockquote in order to have the stability
indication stand out more, while being visually pleasant.
@RomainMuller RomainMuller requested review from skinny85, SoManyHs and a team as code owners June 6, 2019 09:23
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@RomainMuller RomainMuller merged commit da94d8b into master Jun 6, 2019
@RomainMuller RomainMuller deleted the rmuller/stability-banner branch June 6, 2019 09:45
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
This was referenced Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants