Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codebuild): grant the Project's Role permissions to the KMS Key i… #2715

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

skinny85
Copy link
Contributor

…f it was passed.

Without those permissions, uploading the Artifacts after the build will fail.


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
    • Design: For significant features, design document added to design folder
  • Title and Description
    • Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@skinny85 skinny85 requested review from RomainMuller and a team as code owners May 31, 2019 23:51
@skinny85 skinny85 requested a review from rix0rrr May 31, 2019 23:51
…f it was passed.

Without those permissions, uploading the Artifacts after the build will fail.
@skinny85 skinny85 force-pushed the fix/codebuild-kms branch from 73cc797 to 0a5c097 Compare June 1, 2019 01:11
@skinny85 skinny85 merged commit 4e12fe6 into aws:master Jun 3, 2019
@skinny85 skinny85 deleted the fix/codebuild-kms branch June 3, 2019 17:36
@NGL321 NGL321 added the contribution/core This is a PR that came from AWS. label Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants