fix(logs): move log destinations into 'aws-logs-destinations' #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In accordance with new guidelines, we're centralizing cross-service integrations into their own package. In this case, centralizing CloudWatch Logs Subscription Destinations into @aws-cdk/aws-logs-destinations. Fixes #2444. BREAKING CHANGE: using a Lambda or Kinesis Stream as Log Subscription Destination now requires an integration object from the @aws-cdk/aws-logs-destinations package.
eladb
approved these changes
May 29, 2019
|
|
||
| public bind(scope: Construct, _sourceLogGroup: logs.ILogGroup): logs.LogSubscriptionDestination { | ||
| // Following example from https://docs.aws.amazon.com/AmazonCloudWatch/latest/logs/SubscriptionFilters.html#DestinationKinesisExample | ||
| // Create a role to be assumed by CWL that can write to this stream and pass itself. |
There was a problem hiding this comment.
What happens if we want to bind two Kinesis streams? We need only a single role,
Right?
There was a problem hiding this comment.
A single role with multiple statements, yes. The role belongs conceptually to the log group, I would say.
Aren't we better off return an array of policystatements to be added to the role, instead of the role itself?
| const logSubscriptionDestinationPolicyAddedFor: string[] = []; | ||
|
|
||
| if (logSubscriptionDestinationPolicyAddedFor.indexOf(arn) === -1) { | ||
| // NOTE: the use of {AWS::Region} limits this to the same region, which shouldn't really be an issue, |
This was referenced Aug 22, 2019
This was referenced Dec 12, 2019
This was referenced Dec 13, 2019
This was referenced Jan 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing
CloudWatch Logs Subscription Destinations into
@aws-cdk/aws-logs-destinations.
Fixes #2444.
BREAKING CHANGE: using a Lambda or Kinesis Stream as Log Subscription
Destination now requires an integration
object from the @aws-cdk/aws-logs-destinations package.
Pull Request Checklist
designfolderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.