-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-glue): fix glue tableArn and integer schema name #2585
Conversation
Merge from awslabs/aws-cdk
this.tableArn = this.node.stack.formatArn({ | ||
service: 'glue', | ||
resource: 'table', | ||
resourceName: Fn.join('', [this.database.databaseName, '/', this.tableName]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be a string interpolation (what was previously in tableArn
). Why the explicit Fn.Join
? Does something break if we do it the other way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't think to use string interpolation. Fixed now.
Two fixes for aws-glue
Table
:tableArn
according to the docs:database
was mistakenly used as the resource instead oftable
.INTEGER
type frominteger
toint
or else deploying the table fails.Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.