-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-cdk) use ts-node for TypeScript app template #2527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool!
- Can you also please update the sample-app template
- We need to update related documentation like getting started, READMEs, integ tests. Having said that, this is backwards compatible, so I guess we can do those after this is merged.
@rix0rrr any thoughts on this? Objections?
@eladb Updated sample app as well. It's a shame that the documentation is no longer accessible via Github... or is it? Would be great to clean up typos and target areas that need a bit of attention. |
They will eventually be available on GitHub. They are currently going through a reorganization... |
FYI: Every page in the developer guide, https://docs.aws.amazon.com/cdk/latest/guide, has a link to the GitHub repo (https://github.com/awsdocs/aws-cdk-guide, the doc source is in doc_source) where the Markdown (.md) version of the topic is available for PRs. See the black-and-white cat icon on the top of the page. As Elad said, we are still making changes to the docs, so sometimes the GitHub repo lags the current dev guide contents for a bit. Feel free to file an issue if you run into any problems. Just tag it with "guide" so I see it. |
Thanks for the info, Doug!
…On Tue, May 14, 2019 at 6:41 AM Doug ***@***.***> wrote:
FYI: Every page in the developer guide,
https://docs.aws.amazon.com/cdk/latest/guide, has a link to the GitHub
repo (https://github.com/awsdocs/aws-cdk-guide, the doc source is in
doc_source) where the Markdown (.md) version of the topic is available for
PRs. See the black-and-white cat icon on the top of the page.
As Elad said, we are still making changes to the docs, so sometimes the
GitHub repo lags the current dev guide contents for a bit. Feel free to
file an issue if you run into any problems. Just tag it with "guide" so I
see it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2527>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAADWQPLN6ZNIBQVRFZPZUTPVK6R5ANCNFSM4HMJBTKA>
.
|
Closes #1532
Pull Request Checklist
npm run build
shouldn't hurt anything. However it may be possible to omit this build command.cd packages/aws-cdk/
mkdir foo && cd foo
../bin/cdk init app --language=typescript
cdk synth # Resources: {}
cdk list # FooStack
npm run build
which is no longer required.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.