-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-events-targets): centralized module for cloudwatch event targets #2343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gets Start moving all implementations of `IEventRuleTarget` into a centralized module to adhere with the new AWS Construct Library guideline for integrations. This change creates the aws-events-targets module and implements the SNS Topic integration class. Subsequent PRs will migrate the rest of the targets into this module.
rix0rrr
approved these changes
Apr 22, 2019
Move SID assignment from TopicPolicy to PolicyDocument so that it will occur after statement deduplication.
rix0rrr
approved these changes
Apr 22, 2019
piradeepk
pushed a commit
to piradeepk/aws-cdk
that referenced
this pull request
Apr 25, 2019
…gets (aws#2343) Start moving all implementations of `IEventRuleTarget` into a centralized module to adhere with the new AWS Construct Library guideline for integrations. This change includes the implementation of the following event rule targets: - `targets.SnsTopic` - `targets.CodeBuildProject` BREAKING CHANGE: `sns.Topic` no longer implements `IEventRuleTarget`. Use `@aws-cdk/aws-events-targets.SnsTopic` instead. * `codebuild.Project` no longer implements `IEventRuleTarget`. Use `@aws-cdk/aws-events-targets.CodeBuildProject`
SanderKnape
pushed a commit
to SanderKnape/aws-cdk
that referenced
this pull request
May 14, 2019
…gets (aws#2343) Start moving all implementations of `IEventRuleTarget` into a centralized module to adhere with the new AWS Construct Library guideline for integrations. This change includes the implementation of the following event rule targets: - `targets.SnsTopic` - `targets.CodeBuildProject` BREAKING CHANGE: `sns.Topic` no longer implements `IEventRuleTarget`. Use `@aws-cdk/aws-events-targets.SnsTopic` instead. * `codebuild.Project` no longer implements `IEventRuleTarget`. Use `@aws-cdk/aws-events-targets.CodeBuildProject`
Thanks so much for taking the time to contribute to the AWS CDK ❤️ We will shortly assign someone to review this pull request and help get it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start moving all implementations of
IEventRuleTarget
into a centralizedmodule to adhere with the new AWS Construct Library guideline for integrations.
This change includes the implementation of the following event rule targets:
targets.SnsTopic
targets.CodeBuildProject
BREAKING CHANGE:
sns.Topic
no longer implementsIEventRuleTarget
. Use@aws-cdk/aws-events-targets.SnsTopic
instead.codebuild.Project
no longer implementsIEventRuleTarget
. Use@aws-cdk/aws-events-targets.CodeBuildProject
Subsequent PRs will migrate the rest of the targets into this module.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.