Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeBuild: standard image is named incorrectly #2306

Closed
rix0rrr opened this issue Apr 16, 2019 · 0 comments · Fixed by #2541 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Closed

CodeBuild: standard image is named incorrectly #2306

rix0rrr opened this issue Apr 16, 2019 · 0 comments · Fixed by #2541 or MechanicalRock/tech-radar#14 · May be fixed by MechanicalRock/cdk-constructs#5, MechanicalRock/cdk-constructs#6 or MechanicalRock/cdk-constructs#7
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild bug This issue is a bug.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Apr 16, 2019

Describe the bug

This change: 87b1ea0#diff-6e6adffe1993c673ffb7921c741a1decR1029

Renames the default build image to UBUNTU_18_04_STANDARD_01, but it looks like CodeBuild is moving away from guaranteeing a particular distro version, and will be moving to using a moving distro target just labeled as the "standard" image.

We should avoid imposing semantics on their labels, and just call the image "STANDARD_01" as well.
@rix0rrr rix0rrr added bug This issue is a bug. @aws-cdk/aws-codebuild Related to AWS CodeBuild labels Apr 16, 2019
Kaixiang-AWS added a commit to Kaixiang-AWS/aws-cdk that referenced this issue May 14, 2019
@Kaixiang-AWS
feat(codebuild): rename standard 1.0 image and add standard 2.0 image
5751ab1 
Fixes aws#2306
Kaixiang-AWS added a commit to Kaixiang-AWS/aws-cdk that referenced this issue May 14, 2019
@Kaixiang-AWS
feat(codebuild): rename standard 1.0 image and add standard 2.0 image
0fd6fb6 
Fixes aws#2306
@Kaixiang-AWS Kaixiang-AWS mentioned this issue May 14, 2019
Merged
4 tasks
eladb pushed a commit that referenced this issue May 14, 2019
@Kaixiang-AWS
feat(codebuild): rename standard 1.0 image and add standard 2.0 image (…
e4e24ab 
…#2541)

Fixes #2306
This was referenced Aug 22, 2019
Open
Open
Open
Open
Open
This was referenced Dec 12, 2019
Closed
Closed
Closed
Merged
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Jan 20, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(codebuild): rename standard 1.0 image and add standard 2.0 image Kaixiang-AWS/aws-cdk
[Snyk] Upgrade @aws-cdk/aws-iam from 0.22.0 to 0.39.0 MechanicalRock/tech-radar
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-s3 from 0.24.1 to 0.39.0 MechanicalRock/cdk-constructs
[Snyk] Upgrade @aws-cdk/aws-cloudfront from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codebuild from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codecommit from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/aws-codepipeline from 0.15.2 to 0.39.0 MechanicalRock/cdk-products
[Snyk] Upgrade @aws-cdk/cdk from 0.24.1 to 0.35.0 MechanicalRock/account-reaper
1 participant
@rix0rrr