fix(acm) enabled validation of certificates on the zone name #2133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is now, only certificates with subdomains are correctly validated Got help from @njlaw to find and correct the issue
eladb
reviewed
Apr 7, 2019
|
@eladb After some trial and error with the TS tests, i added one test for the root domain case |
eladb
suggested changes
Apr 11, 2019
| @@ -112,4 +112,31 @@ export = { | |||
| test.throws(() => expect(stack), /DNS zone hello.com is not authoritative for certificate domain name example.com/); | |||
| test.done(); | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
This test doesn't seem to verify the new behavior (we need to verify that there's an error thrown when you synthesize)
There was a problem hiding this comment.
Sorry @eladb but i don't think i follow you, i built the test like the previous ones on this test suite, but i am totally inexperienced with writing TS and TS tests so might have missed something?
There was a problem hiding this comment.
You are right, my bad. Looks good.
eladb
approved these changes
Apr 11, 2019
| @@ -112,4 +112,31 @@ export = { | |||
| test.throws(() => expect(stack), /DNS zone hello.com is not authoritative for certificate domain name example.com/); | |||
| test.done(); | |||
| }, | |||
|
|
|||
There was a problem hiding this comment.
You are right, my bad. Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is now, only certificates with subdomains are correctly validated
Got help from @njlaw to find and correct the issue
First PR like this, I hope it looks ok!
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.