fix(rds): remove Instance class #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an instance class which was a placeholder, and didn't have any implementation. Remove to avoid confusing users. Also update the README to be very explicit that RDS is not well-supported.
sam-goodwin
approved these changes
Mar 22, 2019
packages/@aws-cdk/aws-rds/README.md
Outdated
| @@ -2,6 +2,14 @@ | |||
|
|
|||
| The `aws-cdk-rds` package contains Constructs for setting up RDS instances. | |||
|
|
|||
| > Note: this package is currently quite limited, as the CDK team is focusing | |||
| > on other use cases first. If your use case is not in the list below, there is | |||
| > no use coming in to the channel to ask "how do I..." because it won't be | |||
There was a problem hiding this comment.
Getting fed up with the same questions over and over again. But yes, this is probably not the best message to put there. Suggestions?
There was a problem hiding this comment.
+1 you can just point to the escape hatches topic and mention that this is not complete yet.
eladb
approved these changes
Mar 24, 2019
packages/@aws-cdk/aws-rds/README.md
Outdated
| @@ -2,6 +2,14 @@ | |||
|
|
|||
| The `aws-cdk-rds` package contains Constructs for setting up RDS instances. | |||
|
|
|||
| > Note: this package is currently quite limited, as the CDK team is focusing | |||
| > on other use cases first. If your use case is not in the list below, there is | |||
| > no use coming in to the channel to ask "how do I..." because it won't be | |||
There was a problem hiding this comment.
+1 you can just point to the escape hatches topic and mention that this is not complete yet.
|
FYI I'm working on a PR to add DB instance support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an instance class which was a placeholder, and didn't have any
implementation. Remove to avoid confusing users.
Also update the README to be very explicit that RDS is not
well-supported.
Pull Request Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.