-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: PipelineProject badge error #1749
Bug: PipelineProject badge error #1749
Comments
As the error says, I don't believe badges are supported for a PipelineProject, you should use a regular We should add a validation in |
Ah ha, yeah I just noticed that. Yeah probably should take it out then.
…On Tue, Feb 12, 2019, 22:57 Elad Ben-Israel ***@***.***> wrote:
As the error says, I don't believe badges are supported for a
PipelineProject, you should use a regular codebuild.Project construct
instead.
We should add a validation in PipelineProject (or even better, remove
this property from PipelineProject).
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1749 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACDIwhzffF1ZxRhaL1277RDS4JciRn6Gks5vM7dggaJpZM4a4MLp>
.
|
Badge should not be allow to set to true if source is not GITHUB, GITHUB_ENTERPRISE or BITBUCKET Fixes aws#1749
Hi @jamiepmullan , like the error says:
this is actually a CodeBuild limitation - there's nothing we can do in the CDK to ad support for these, since the service itself doesn't support this usecase. Sorry! |
With today I released an AWS CDK custom construct for creating badges with using a lambda https://github.com/mmuller88/aws-cdk-build-badge |
When creating a new PipelineProject I get an error when trying to enable badge
The text was updated successfully, but these errors were encountered: