Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION]Addition of LOG_LEVEL_PROFILE in Ver1.8.0 and its implications #1804

Closed
YOSI-yoshidayuji opened this issue Sep 12, 2023 · 3 comments
Labels
question Further information is requested

Comments

@YOSI-yoshidayuji
Copy link

LOG_LEVEL_PROFILE has been added in Ver1.8.0.
It is defined as follows:

#define LOG_LEVEL_VERBOSE 1
#define LOG_LEVEL_DEBUG 2
#define LOG_LEVEL_INFO 3
#define LOG_LEVEL_WARN 4
#define LOG_LEVEL_ERROR 5
#define LOG_LEVEL_FATAL 6
#define LOG_LEVEL_SILENT 7
#define LOG_LEVEL_PROFILE 8

Even if you specify LOG_LEVEL_SILENT, you cannot suppress the logs because LOG_LEVEL_PROFILE is the strongest.
Doesn't this seem strange considering the meaning of LOG_LEVEL_SILENT ?
Personally, I feel that it would be more appropriate to have the strength between LOG_LEVEL_INFO and LOG_LEVEL_WARN.

@YOSI-yoshidayuji YOSI-yoshidayuji added needs-triage question Further information is requested labels Sep 12, 2023
@niyatim23
Copy link
Contributor

Hi @YOSI-yoshidayuji, thanks for reporting this. We will look into this

@sirknightj
Copy link
Contributor

@stefankiesz
Copy link
Contributor

@YOSI-yoshidayuji, thank you for pointing this out, we have addressed it in the above PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants