[QUESTION]The definition of KVS_USE_SIGNALING_CHANNEL_THREADPOOL is not found in the SDK build.

[YOSI-yoshidayuji]

README.md says "The threadpool is enabled by default," But I can't found add_definitions(-DKVS_USE_SIGNALING_CHANNEL_THREADPOOL) in CMakeLists.txt

I modified the function 'createSignalingSync' in Signaling.c for verification purposes.

#ifdef KVS_USE_SIGNALING_CHANNEL_THREADPOOL
printf( "threadpool create !\n" );
CHK_STATUS(threadpoolCreate(&pSignalingClient->pThreadpool, pClientInfo->signalingClientInfo.signalingMessagesMinimumThreads,
pClientInfo->signalingClientInfo.signalingMessagesMaximumThreads));
#else
printf( "No treadpool \n" );
#endif

When I build it normally, "No threadpool" is displayed. When I write add_definitions(-DKVS_USE_SIGNALING_CHANNEL_THREADPOOL), "threadpool create!" is displayed.
Am I misunderstanding something?

[niyatim23]

Hi @YOSI-yoshidayuji, it is defined in the samples here:

amazon-kinesis-video-streams-webrtc-sdk-c/samples/Samples.h

Lines 59 to 60 in 15e6019

	// comment out this line to disable the feature
	#define KVS_USE_SIGNALING_CHANNEL_THREADPOOL 1

It seems like you're creating your own application is why it is missing for you. You can define it the similar to above from our sample application

[disa6302]

@YOSI-yoshidayuji ,

It does seem we are missing the add definition in the CMake file. Thank you for pointing it out!
Would you like to open a PR with the flag change?

[YOSI-yoshidayuji]

Thank you for your response.
According to the regulations of my organization, I do not wish to open in PR.

[disa6302]

No problem :)
Keeping this ticket open till we have the cmake fix merged. Thanks for reporting again!

[niyatim23]

We have a new CMake flag for this now ENABLE_KVS_THREADPOOL. Currently only available in develop