Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct missing defined in include file #257

Closed
wants to merge 1 commit into from

Conversation

rob-baily
Copy link
Contributor

Issue #, if available: N/A

What was changed? Correct to use "defined" for preprocessor check.

Why was it changed? Receive a compiler warning with it as is.
warning: "__aarch64__" is not defined [-Wundef] #if defined __x86_64__ || defined __ppc64__ || __aarch64__

How was it changed? VS Code

What testing was done for the changes? CI

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sirknightj sirknightj changed the base branch from master to develop October 11, 2024 18:19
@sirknightj
Copy link
Contributor

sirknightj commented Nov 5, 2024

Hi @rob-baily, thanks for your contribution. Can you rebase your changes to the latest develop branch please? I've fixed the CI over there as part of #261 and we need to rebase to have the updated CI run for your changes.

@rob-baily
Copy link
Contributor Author

Sorry for the confusion. Created #265 based off of develop and I am closing this one.

@rob-baily rob-baily closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants