Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complete Kubernetes version in CHANGELOG.md #339

Closed
bhavin192 opened this issue Sep 26, 2019 · 3 comments
Closed

Add complete Kubernetes version in CHANGELOG.md #339

bhavin192 opened this issue Sep 26, 2019 · 3 comments
Labels
documentation Documentation issue

Comments

@bhavin192
Copy link

bhavin192 commented Sep 26, 2019

What would you like to be added:
It will be great if we add complete Kubernetes version i.e. major.minor.patch to the CHANGELOG.md file as well in the release note. Will be awesome if we can add it to the AMI name as well.

Why is this needed:
The only way to get the version and date is the Makefile. But this file will be update as we do a new release. kubernetes_build_date and the kubernetes_version are required to build the AMI. Having those in CHANGELOG.md and release notes will make it easy to find out and build custom AMI.

For example, I want to build AMI for this release https://github.com/awslabs/amazon-eks-ami/releases/tag/v20190906 but I don't know what should be the kubernetes_version for 1.12, 1.13 and so on.

@mogren mogren added the documentation Documentation issue label Sep 26, 2019
@TonyLovesDevOps
Copy link

This is confusing for me too; why is the Makefile not updated to reflect the kubernetes_version and kubernetes_build_date used to generate the official AWS EKS AMI that corresponds to the latest release?

@M00nF1sh
Copy link
Member

M00nF1sh commented Dec 19, 2019

@TonyFlint
Hi, we have an internal pipeline with configurations for the binary_bucket_name and kubernetes_build_date. And the pipeline is building AMIs with make k8s binary_bucket_name=${} kubernetes_build_date=${} instead of these make 1.11. The binary versions and kubernetes_build_date is published in release notes.

I think it's better to publish latest bucket as an SSM parameter instead of manually updating this file is better(which is hard to automate)

@mmerkes
Copy link
Member

mmerkes commented Feb 25, 2021

I believe that this issue is now resolved. The changelog includes the kubernetes full version and the build date of the binaries used, like this: s3://amazon-eks/1.19.6/2021-01-05/, which would be converted to a command like this: make k8s kubernetes_version=1.19.6 kubernetes_build_date=2021-01-05 pull_cni_from_github=true.

As for the AMI ID, that information can be found here for the latest version.

If you asking for additional info, please open a new issue with the details.

@mmerkes mmerkes closed this as completed Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation issue
Projects
None yet
Development

No branches or pull requests

5 participants