Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no mention of --balancing-ignore-label #411

Closed
nbrational opened this issue Jul 23, 2021 · 3 comments
Closed

no mention of --balancing-ignore-label #411

nbrational opened this issue Jul 23, 2021 · 3 comments
Assignees

Comments

@nbrational
Copy link

nbrational commented Jul 23, 2021

This relates to issue kubernetes/autoscaler#3515

When using --balance-similar-node-groups=true to balance scaling across multiple node groups, each in a different AZ, scaling across node group ASGs is not uniform unless all node labels match.

I created 3 node groups using eksctl (each in a different AZ) and found that a node label eks.amazonaws.com/sourceLaunchTemplateId (and possibly eks.amazonaws.com/sourceLaunchTemplateVersion) is different across nodes of different node groups. Scaling was not uniform unless I passed --balancing-ignore-label=eks.amazonaws.com/sourceLaunchTemplateId. This labels is not covered in the list of aws ignored labels or BasicIgnoredLabels.

Think it will be useful to include a note in documentation so that user can compare the node labels and pass --balancing-ignore-label for each label that needs ignoring.

@stevehipwell
Copy link

You'll also need kubernetes/autoscaler#3673 to be fixed and the chart to be released (CA chart releases are a manual process after the PR has been merged and the chart has been built).

@stevehipwell
Copy link

I've opened kubernetes/autoscaler#4228 to request better defaults and documentation around the ignore labels.

@pgasca
Copy link
Contributor

pgasca commented Dec 14, 2021

I've handled incorporating this information as part of incorporating content for PR. I'm waiting on an engineer to do full confirmation on my summary. But feel free to re-open if there's a need beyond what will be covered with PR: "When setting --balance-similar-node-groups to true, make sure that the node groups you want the Cluster Autoscaler to balance have matching labels (except for automatically added zone labels). You can pass a --balancing-ignore-label flag to nodes with different labels to balance them regardless, but this should only be done as needed."

@pgasca pgasca closed this as completed Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants