Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate parsing reports S2N_ERR_CERT_UNTRUSTED instead of S2N_ERR_DECODE_CERTIFICATE #4270

Closed
lrstewart opened this issue Oct 30, 2023 · 0 comments · Fixed by #4271
Closed
Labels

Comments

@lrstewart
Copy link
Contributor

Problem:

If s2n-tls receives a cert with an unsupported curve like secp192k1, it reports S2N_ERR_CERT_UNTRUSTED instead of a more accurate error like S2N_ERR_DECODE_CERTIFICATE, S2N_ERR_CERT_TYPE_UNSUPPORTED or S2N_ERR_CERT_INVALID. This was particularly confusing for a customer that had disabled certificate validation.

Solution:

This line needs to use GUARD instead of ENSURE, so that the actual underlying error is passed up. We'll also want to convert s2n_asn1der_to_public_key_and_type to s2n_result to make sure it's not returning anything non-standard like other functions in x509 have in the past.

  • Does this change what S2N sends over the wire? If yes, explain.
  • Does this change any public APIs? If yes, explain.
  • Which versions of TLS will this impact?

Requirements / Acceptance Criteria:

What must a solution address in order to solve the problem? How do we know the solution is complete?

  • RFC links: Links to relevant RFC(s)
  • Related Issues: Link any relevant issues
  • Will the Usage Guide or other documentation need to be updated?
  • Testing: How will this change be tested? Call out new integration tests, functional tests, or particularly interesting/important unit tests.
    • Will this change trigger SAW changes? Changes to the state machine, the s2n_handshake_io code that controls state transitions, the DRBG, or the corking/uncorking logic could trigger SAW failures.
    • Should this change be fuzz tested? Will it handle untrusted input? Create a separate issue to track the fuzzing work.

Out of scope:

Is there anything the solution will intentionally NOT address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants