From 2c8eef53b2109211752c9ef3635557d280217226 Mon Sep 17 00:00:00 2001 From: Appelmans Date: Wed, 27 Mar 2024 11:44:18 -0700 Subject: [PATCH] PR feedback --- tests/unit/s2n_traffic_context_test.c | 2 +- tls/s2n_connection.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/s2n_traffic_context_test.c b/tests/unit/s2n_traffic_context_test.c index 9e0a8b313f7..857924d0695 100644 --- a/tests/unit/s2n_traffic_context_test.c +++ b/tests/unit/s2n_traffic_context_test.c @@ -122,7 +122,7 @@ int main(int argc, char **argv) /* Negotiation must be complete before calling this function */ EXPECT_SUCCESS(s2n_config_set_traffic_context_version(config, S2N_TRAFFIC_CONTEXT_V1)); EXPECT_FAILURE_WITH_ERRNO(s2n_connection_get_traffic_context(conn, buffer, length), - S2N_ERR_INVALID_STATE); + S2N_ERR_HANDSHAKE_NOT_COMPLETE); /* Buffer must be large enough to hold entire traffic context */ EXPECT_OK(s2n_skip_handshake(conn)); diff --git a/tls/s2n_connection.c b/tls/s2n_connection.c index 2148b6d6d46..4d25cd0adbd 100644 --- a/tls/s2n_connection.c +++ b/tls/s2n_connection.c @@ -1758,7 +1758,7 @@ int s2n_connection_get_traffic_context(struct s2n_connection *conn, uint8_t *buf POSIX_ENSURE(conn->config->traffic_context != S2N_TRAFFIC_CONTEXT_NONE, S2N_ERR_INVALID_STATE); /* This method must be called after negotiation */ - POSIX_ENSURE(s2n_handshake_is_complete(conn), S2N_ERR_INVALID_STATE); + POSIX_ENSURE(s2n_handshake_is_complete(conn), S2N_ERR_HANDSHAKE_NOT_COMPLETE); /* Best effort check for pending input or output data. * This method should not be called until the application has stopped sending and receiving.