Fix logic for handling custom jobs #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aggarw13
commented
Feb 15, 2021
•
aggarw13
commented
- Improve handling of custom jobs by calling the user-defined callback only if the Job ID and job document data can be parsed from JSON payload.
- Remove instances of custom callback from from API
aggarw13
force-pushed
the
hygiene/custom-job-handling
branch
from
4ddc82f to
f4046d5
Compare
aggarw13
force-pushed
the
hygiene/custom-job-handling
branch
2 times, most recently
from
907014f to
2f9906f
Compare
yanjos-dev
reviewed
Feb 16, 2021
n9wxu
reviewed
Feb 17, 2021
| static OtaJobParseErr_t parseJobDocFromCustomCallback( const char * pJson, | ||
| uint32_t messageLength ); | ||
| static OtaJobParseErr_t handleCustomJob( const char * pJson, | ||
| uint32_t messageLength ); |
There was a problem hiding this comment.
The messageLength parameter comes from parseJobDoc function. Changing the type across the function call chain would be out of scope of this PR.
n9wxu
reviewed
Feb 17, 2021
| uint32_t messageLength ) | ||
| /* If there is an error in parsing the json, check if it can be handled by external callback. */ | ||
| static OtaJobParseErr_t handleCustomJob( const char * pJson, | ||
| uint32_t messageLength ) |
There was a problem hiding this comment.
Same as this reply.
n9wxu
approved these changes
Feb 17, 2021
yanjos-dev
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.