Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use darwin instead of mac for kubernetes.io/os label #941

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

tuananh
Copy link
Contributor

@tuananh tuananh commented Dec 8, 2021

Signed-off-by: Tuan Anh Tran [email protected]

1. Issue, if available:

2. Description of changes:

i thought kubernetes.io/os values is from runtime.GOOS as defined by Go. the list is here
https://github.com/golang/go/blob/a19e72cb89fd33e5bf1474887e267806f65b7a40/src/go/build/syslist.go#L10

const goosList = "aix android darwin dragonfly freebsd hurd illumos ios js linux nacl netbsd openbsd plan9 solaris windows zos "

in there, macOS is darwin instead of mac.

https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-os

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Dec 8, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 2d617a6

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61b037ff8a210c00075ed878

@ellistarn ellistarn merged commit 460b66e into aws:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants