fix: use darwin instead of mac for kubernetes.io/os label #941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tuan Anh Tran [email protected]
1. Issue, if available:
2. Description of changes:
i thought
kubernetes.io/os
values is fromruntime.GOOS
as defined by Go. the list is herehttps://github.com/golang/go/blob/a19e72cb89fd33e5bf1474887e267806f65b7a40/src/go/build/syslist.go#L10
in there, macOS is darwin instead of
mac
.https://kubernetes.io/docs/reference/labels-annotations-taints/#kubernetes-io-os
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.