Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where spot capacity was not prioritized if flexible to both spot and on demand capacity #893

Merged
merged 5 commits into from
Dec 3, 2021

Conversation

ellistarn
Copy link
Contributor

@ellistarn ellistarn commented Dec 2, 2021

1. Issue, if available:

2. Description of changes:

  • AWS Cloud Provider defaults to [ on-demand ] if nothing is specified
  • if [ on-demand, spot ] is specified, spot will be prioritized if offerings are available
  • if spot offerings become unavailable, on demand will be selected

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Dec 2, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 501e407

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61a941326eb3190008db39d0

@ellistarn ellistarn changed the title Fixed a bug where spot capacity was not prioritized if flexible to bo… Fixed a bug where spot capacity was not prioritized if flexible to both spot and on demand capacity Dec 2, 2021
eptiger
eptiger previously approved these changes Dec 2, 2021
Copy link
Contributor

@eptiger eptiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Sorry I missed this for the v0.5 release, but glad you caught it.

@ellistarn ellistarn merged commit 4daa335 into aws:main Dec 3, 2021
@ellistarn ellistarn deleted the spot branch December 3, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants