Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support custom CNIs #888

Merged
merged 1 commit into from
Dec 1, 2021
Merged

Support custom CNIs #888

merged 1 commit into from
Dec 1, 2021

Conversation

tiagoposse
Copy link
Contributor

1. Issue, if available:
When using a custom CNI in AWS EKS, the control plane will not run in same CNI, so to use webhooks, they must be exposed via the host network.

2. Description of changes:
Add hostNetwork flag to webhook deployment

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Dec 1, 2021

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 7ce7e3e

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61a7a880df3e89000702df34

😎 Browse the preview: https://deploy-preview-888--karpenter-docs-prod.netlify.app

Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tiagoposse
Copy link
Contributor Author

No no, thank you! This project is awesome.

@ellistarn ellistarn merged commit 2efa750 into aws:main Dec 1, 2021
@tiagoposse tiagoposse deleted the support_custom_cnis branch December 2, 2021 06:02
@FernandoMiguel
Copy link
Contributor

@tiagoposse i've been testing this value with true/false, on a cluster that has CNI Custom Network enabled, vpc-cni plugin, Prefix Delegation, and extended subnets.
it does not seem to make any difference.
can you clarify exactly when this is required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants