Implements a temporary hack to resolve an issue where the LoadBalance… #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r controller requires a single security group with the cluster discovery tag
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 8629fb4 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/619c210f687e3b0007ef6531 |
bwagner5
reviewed
Nov 22, 2021
| return output.SecurityGroups, nil | ||
| } | ||
|
|
||
| func (s *SecurityGroupProvider) securityGroupIds(securityGroups []*ec2.SecurityGroup) []string { | ||
| func filterClusterTaggedGroups(ctx context.Context, securityGroups []*ec2.SecurityGroup) []*ec2.SecurityGroup { |
There was a problem hiding this comment.
No receivers to confine this to securitygroups instead of exposing to all of aws pkg?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r controller requires a single security group with the cluster discovery tag
1. Issue, if available:
2. Description of changes:
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.