add GitHub stars button #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffcline
added
the
hacking
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 1ee359e 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/619bf403e8def600088f1741 😎 Browse the preview: https://deploy-preview-829--karpenter-docs-prod.netlify.app |
geoffcline
force-pushed
the
gdc-github-star
branch
from
900a54b to
20f81a6
Compare
ellistarn
reviewed
Nov 20, 2021
| @@ -294,7 +294,7 @@ kubectl delete node $NODE_NAME | |||
|
|
|||
| ## Cleanup | |||
|
|
|||
| To avoid additional charges, remove the demo infrastructure from your AWS account. | |||
| To avoid additional charges, remove the demo infrastructure from your AWS account. Party. | |||
There was a problem hiding this comment.
I think I typed this because I couldn't figure out why Hugo wasn't updating. I was on karpenter.sh and not localhost............
ellistarn
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#828
2. Description of changes:
Add GitHub stars button to homepage and getting started guide.
It fetches the current star count with a basic get request to api.github.com
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.