Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where daemonsets weren't correctly included in binpacking calculations #814

Merged
merged 2 commits into from
Nov 20, 2021

Conversation

ellistarn
Copy link
Contributor

1. Issue, if available:

2. Description of changes:

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Nov 19, 2021

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: fcad6fd

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61983b707b1b3a00089b5b9d

😎 Browse the preview: https://deploy-preview-814--karpenter-docs-prod.netlify.app

@ellistarn ellistarn changed the title Fixed a bug where daemonsets weren't correctly factored in [wip] Fixed a bug where daemonsets weren't correctly included in binpacking calculations Nov 19, 2021
@ellistarn ellistarn changed the title [wip] Fixed a bug where daemonsets weren't correctly included in binpacking calculations Fixed a bug where daemonsets weren't correctly included in binpacking calculations Nov 19, 2021
Copy link
Contributor

@JacobGabrielson JacobGabrielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@JacobGabrielson JacobGabrielson merged commit 3ed8570 into aws:main Nov 20, 2021
@ellistarn ellistarn deleted the ds branch November 22, 2021 16:24
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants