Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out if no subnets found #807

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Conversation

JacobGabrielson
Copy link
Contributor

1. Issue, if available:

N/A

2. Description of changes:

Before, if zero subnets were found (via the tag), the controller would continue on, even though there is no way for it to launch any instances. Now it errors with a message like:

2021-11-16T16:55:19.034Z	ERROR	controller.controller.Allocation	Reconciler error	{"commit": "53cd6c4", "reconciler group": "karpenter.sh", "reconciler kind": "Provisioner", "name": "default", "namespace": "", "error": "getting instance types, no subnets found via [{\"Name\":\"tag-key\",\"Values\":[\"kubernetes.io/cluster/foo-karpenter-demo.us-west-2.eksctl.io\"]}]"}

3. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

with useful error message
@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: dde182f

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6193e44fcf680b00071e06ea

ellistarn
ellistarn previously approved these changes Nov 16, 2021
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reference something like spec.provider.subnetSelector= so the user knows where to look?

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@JacobGabrielson JacobGabrielson merged commit ca6fa8b into aws:main Nov 16, 2021
@JacobGabrielson JacobGabrielson deleted the debugg branch November 16, 2021 17:15
gfcroft pushed a commit to gfcroft/karpenter-provider-aws that referenced this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants