Create main Karpenter concepts doc #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 26cee2e 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6196fe840d0ae30008a12e1d 😎 Browse the preview: https://deploy-preview-777--karpenter-docs-prod.netlify.app |
|
See the preview here: https://deploy-preview-777--karpenter-docs-prod.netlify.app/docs/concepts/ |
|
/assign @ellistarn |
ellistarn
reviewed
Oct 29, 2021
chrisnegus
commented
Nov 1, 2021
There was a problem hiding this comment.
@ellistarn I went through your comments and responded to most of them. I left the ones unresolved that I had further questions about. Now that I've done the smaller changes, I'm going to look at your suggestions for reorganizing the content.
eptiger
reviewed
Nov 10, 2021
chrisnegus
changed the title
ellistarn
previously approved these changes
Nov 18, 2021
chrisnegus
commented
Nov 19, 2021
ellistarn
approved these changes
Nov 19, 2021
|
/assign @bwagner5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
No particular issue.
2. Description of changes:
Added a new Concepts section to the docs. This includes the main Concepts page and stubs for more in-depth concepts docs that I will add later.
3. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.