Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding SGP workaround to troubleshooting docs #1625

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

dewjam
Copy link
Contributor

@dewjam dewjam commented Apr 5, 2022

1. Issue, if available:
#1252

2. Description of changes:
Adding workaround for using Security Groups for Pods with Karpenter.

3. How was this change tested?
Tested the workaround with a variety of vpc.amazonaws.com/pod-eni resources applied to pods. Pods were able to start without delay.

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dewjam dewjam requested a review from a team as a code owner April 5, 2022 17:13
@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for karpenter-docs-prod ready!

Name Link
🔨 Latest commit 6c73ea8
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/624dddd5819c6b000829b04d
😎 Deploy Preview https://deploy-preview-1625--karpenter-docs-prod.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small suggestion. Othewise, lgtm.

website/content/en/preview/troubleshooting.md Outdated Show resolved Hide resolved
@dewjam dewjam force-pushed the troubleshooting branch 3 times, most recently from 0d7fee9 to b1209b6 Compare April 5, 2022 21:56
@dewjam dewjam requested review from chrisnegus and bwagner5 April 6, 2022 16:20
bwagner5
bwagner5 previously approved these changes Apr 6, 2022
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 enabled auto-merge (squash) April 6, 2022 16:53
@bwagner5 bwagner5 requested review from chrisnegus and removed request for chrisnegus April 6, 2022 16:54
Copy link
Member

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small fix, then it's good to go, as far as I am concerned.

website/content/en/preview/troubleshooting.md Outdated Show resolved Hide resolved
@chrisnegus
Copy link
Member

/lgtm

@bwagner5 bwagner5 merged commit 3858fae into aws:main Apr 6, 2022
@suket22 suket22 mentioned this pull request May 23, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants