Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use dockerd if requesting gpus #1588

Merged
merged 1 commit into from
Mar 29, 2022
Merged

use dockerd if requesting gpus #1588

merged 1 commit into from
Mar 29, 2022

Conversation

bwagner5
Copy link
Contributor

1. Issue, if available:
#1585

2. Description of changes:

  • The AL2 AMI Family now uses containerd by default and dockerd only when requesting GPUs for
  • Fixed a bug where AMD GPU resources were counted as nvidia resources on the node.

3. How was this change tested?

  • manual cluster test of nvidia gpu pods
  • added unit-tests

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bwagner5 bwagner5 requested a review from a team as a code owner March 29, 2022 17:44
@netlify
Copy link

netlify bot commented Mar 29, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 3782710
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/624345835613a10008cecc34

@bwagner5 bwagner5 requested a review from tzneal March 29, 2022 17:44
@@ -152,7 +152,7 @@ func (i *InstanceType) amdGPUs() resource.Quantity {
count := int64(0)
if i.GpuInfo != nil {
for _, gpu := range i.GpuInfo.Gpus {
if *gpu.Manufacturer == "NVIDIA" {
if *gpu.Manufacturer == "AMD" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pulled and verified that I now get containerd by default on my cluster.

@bwagner5 bwagner5 merged commit 476804d into aws:main Mar 29, 2022
@bwagner5 bwagner5 deleted the containerd branch March 29, 2022 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants