Nightly release #1577
Nightly release #1577
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| - uses: aws-actions/configure-aws-credentials@v1 | ||
| with: | ||
| role-to-assume: arn:aws:iam::112855948879:role/nightly | ||
| aws-region: us-east-1 |
There was a problem hiding this comment.
Is this your role and region? Can we do us-west-2? Should we have builds for different regions? Or is this because of ecr-public?
There was a problem hiding this comment.
It's the default region, the role is made through the infra piece.
There was a problem hiding this comment.
We don't need to have ECRs in each region, what's the reason for using us-west-2? this is already made and tested it's not super easy to change it. us-east-1 as the default region has a lot of capacity and is arguably better geographically positioned to serve the world although the outcome is most likely cached.
There was a problem hiding this comment.
just to note, us-east-1 is the only region where ecr-public is available anyways, but ecr-public replicates out the images to its CDN.
|
@njtran thank you for your comments lets continue the conversation on these concerns, I'm gonna incorporate them in the following PRs I'm working on. |
1. Issue, if available:
2. Description of changes:
Runs everyday half an hour after other scheduled daily crons (#1576)
Releases an image into the karpenter-nightly repository.
Remaining things to do:
1- Add a "Latest" tag
2- Add usage and about docs to the repo
3- Upload a logo to the registry
4- Add an alias in the registry for a friendlier repo name
5- Possibly publish helm charts as well
6- Add the version tag if possible as well
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.