Switch to prism syntax highlighting for website #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
ellistarn
approved these changes
Mar 24, 2022
|
The color coding sometimes doesn't make sense, look at this example where open is colored red in both lines while in one it's an executable binary and in the other a parameter. |
|
That's interesting on the color differences. There are a few other tweaks we can play with in the config to try and make it consistent. We could also try bringing in some of the optional language support https://prismjs.com/download.html#themes=prism |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
Switch hugo theme code blocks to render with prism so code blocks have a copy button
3. How was this change tested?
It was not tested locally but I can verify it with the PR site provided by opening this PR.
I should mention the docs for it are here https://www.docsy.dev/docs/adding-content/lookandfeel/#code-highlighting-with-prism
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.