Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log the version string on startup #1571

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Mar 24, 2022

1. Issue, if available:
N/A

2. Description of changes:
Adds a log line with the version number on startup

3. How was this change tested?
make apply
4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tzneal
Copy link
Contributor Author

tzneal commented Mar 24, 2022

I pulled the v0.7.2 images that were build & published with ko and confirmed that they had the correct version symbol defined:

$ readelf -Ws controller | grep project.Version
 84373: 0000000003ba82a0    16 OBJECT  GLOBAL DEFAULT   10 github.com/aws/karpenter/pkg/utils/project.Version
 89395: 0000000002751d34     7 OBJECT  GLOBAL DEFAULT    2 github.com/aws/karpenter/pkg/utils/project.Version.str

$ readelf -x2 controller  | grep 2751d30
  0x02751d30 fdff0000 76302e37 2e320000 00000000 ....v0.7.2......

cmd/controller/main.go Outdated Show resolved Hide resolved
@tzneal tzneal force-pushed the log-version-on-startup branch from 0e40900 to c377fca Compare March 24, 2022 17:17
@netlify
Copy link

netlify bot commented Mar 24, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 58760b4
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/623caca832ed3c0008552346

@tzneal tzneal force-pushed the log-version-on-startup branch from c377fca to 58760b4 Compare March 24, 2022 17:38
@tzneal tzneal merged commit a2c8d2c into aws:main Mar 24, 2022
@tzneal tzneal deleted the log-version-on-startup branch March 24, 2022 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants