Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved a few libraries to be more generically accessible #1564

Merged
merged 1 commit into from
Mar 23, 2022

Conversation

ellistarn
Copy link
Contributor

1. Issue, if available:

2. Description of changes:
Moved cloud provider specific requirements logic out of the provisioner/scheduling package to make it more accessible to other controllers.

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 23, 2022

Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit a865237
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/623b6c0b72cff500098146ff

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ellistarn ellistarn merged commit 850d51e into aws:main Mar 23, 2022
@ellistarn ellistarn deleted the touchup branch March 23, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants