Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled kubectl delete karpenter --all with crd categories #1506

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ellistarn
Copy link
Contributor

1. Issue, if available:

2. Description of changes:
Simple ease-of-use tweak to karpenter CRD.

k delete karpenter --all
provisioner.karpenter.sh "default" deleted

😮

https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#categories
https://book.kubebuilder.io/reference/markers/crd.html

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 14, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 43c2bda

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/622e8a1846be910009ac641f

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works, LGTM

@ellistarn ellistarn merged commit 3266cdc into aws:main Mar 14, 2022
@ellistarn ellistarn deleted the categories branch March 14, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants