-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More random pod names in tests #1498
Merged
spring1843
merged 2 commits into
aws:main
from
spring1843:rm/add-randomness-and-sequence-to-test-pods
Mar 12, 2022
Merged
More random pod names in tests #1498
spring1843
merged 2 commits into
aws:main
from
spring1843:rm/add-randomness-and-sequence-to-test-pods
Mar 12, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndom number to test pod names
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 0c1828b 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/622aa5c4fdb505000911d6d0 |
…e a very strong randomizer
tzneal
reviewed
Mar 11, 2022
tzneal
approved these changes
Mar 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This was referenced Sep 3, 2023
This was referenced Sep 12, 2023
This was referenced Sep 20, 2023
This was referenced Sep 27, 2023
This was referenced Oct 4, 2023
This was referenced Oct 11, 2023
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
2. Description of changes:
We are seeing collisions in pod names which cause failures in tests. This adds a sequential number to pods making it easier to debug and also adds a random number to make collisions much harder.
Generates names like
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.