Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More random pod names in tests #1498

Merged
merged 2 commits into from
Mar 12, 2022
Merged

More random pod names in tests #1498

merged 2 commits into from
Mar 12, 2022

Conversation

spring1843
Copy link
Contributor

@spring1843 spring1843 commented Mar 11, 2022

1. Issue, if available:

2. Description of changes:
We are seeing collisions in pod names which cause failures in tests. This adds a sequential number to pods making it easier to debug and also adds a random number to make collisions much harder.

Generates names like

P0002-Butterflyfire-060061
P0003-Knavesticky-007571
P0004-Whipflannel-031521
P0005-Ratpalm-084815
P0006-Turnersurf-050034
P0007-Toucanmesquite-005050
P0008-Faceveil-088540
P0009-Graspproud-027227
P0010-Thunderbevel-039678
P0011-Wizardpeat-023014
P0012-Banehollow-067513
P0013-Llamaplanet-021244
P0014-Finsprinkle-097644
P0015-Bootspiral-064129
P0016-Scourgecat-001877
P0017-Sharksand-029673
P0018-Bearthorn-073803
P0019-Lightningflax-050540
P0020-Swordspiral-095658
P0021-Flyplatinum-010365
P0022-Hawkwool-004579
P0023-Flytrail-079776
P0024-Robinlavender-081494
P0025-Tongueflannel-075953
P0026-Herostone-008204
P0027-Roversilver-033833
P0028-Tailfreckle-029469
P0029-Ridertar-026176
P0030-Trackerruby-042623
P0031-Pixieholy-019056
P0032-Storkdaffodil-047686
P0033-Devourertruth-010707
P0034-Sagestripe-065869
P0035-Terriertwisty-027258
P0036-Falconglimmer-004378
P0037-Goosesunset-044895

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 11, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 0c1828b

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/622aa5c4fdb505000911d6d0

Copy link
Contributor

@tzneal tzneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spring1843 spring1843 merged commit 0c6d65a into aws:main Mar 12, 2022
@spring1843 spring1843 deleted the rm/add-randomness-and-sequence-to-test-pods branch March 25, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants