add pod affinity/anti-affinity tests that are skip()'d #1484
Conversation
|
✔️ Deploy Preview for karpenter-docs-prod canceled. 🔨 Explore the source changes: 59a87c1 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/6227b7f2a391460008f4f9fd |
| ExpectScheduled(ctx, env.Client, pod) | ||
| }) | ||
| It("should respect pod affinity", func() { | ||
| Skip("enable after pod-affinity is finished") |
There was a problem hiding this comment.
Can we put the skip directive at the context level?
There was a problem hiding this comment.
No, there was a feature request for that feature with ginkgo but it wasn't implemented.
tzneal
force-pushed
the
add-skipped-affinity-tests
branch
from
aabc7d4 to
0ddc478
Compare
| @@ -207,6 +207,48 @@ var _ = Describe("Allocation", func() { | |||
| } | |||
| Expect(nodeNames.Len()).To(Equal(2)) | |||
| }) | |||
| It("should not schedule a non-GPU workload on a node w/GPU", func() { | |||
There was a problem hiding this comment.
Is there any way we can make this a vendor neutral test?
There was a problem hiding this comment.
Once GPU support itself is vendor neutral, I think this will come along with that.
| var _ = Describe("Incompatible pod networking", func() { | ||
| Context("container HostPort usage", func() { | ||
| It("shouldn't co-locate pods that use the same HostPort and protocol", func() { | ||
| Skip("enable after scheduler is aware of hostport usage") |
There was a problem hiding this comment.
similar re the higher level skip.
There was a problem hiding this comment.
Not supported in ginkgo
This sets up some groundwork for beginning work on pod affinity/anti-affinity.
tzneal
force-pushed
the
add-skipped-affinity-tests
branch
from
0ddc478 to
59a87c1
Compare
1. Issue, if available:
N/A
2. Description of changes:
This sets up some groundwork for beginning work on pod affinity/anti-affinity.
3. How was this change tested?
Unit tests
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.