Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set a grace period of zero when cleaning up between tests #1483

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Mar 8, 2022

1. Issue, if available:
N/A

2. Description of changes:

Remove grace period when cleaning up between tests.

3. How was this change tested?

Hard-coded a pod name in two different tests, without this change the second test fails due to 'object is being deleted'. With this change, both tests pass.

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This should reduce some test flakiness.
@netlify
Copy link

netlify bot commented Mar 8, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: 188989c

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62276c4e75bc2a000772c48f

😎 Browse the preview: https://deploy-preview-1483--karpenter-docs-prod.netlify.app

@tzneal tzneal requested a review from bwagner5 March 8, 2022 15:00
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bwagner5 bwagner5 merged commit 512b7e7 into aws:main Mar 8, 2022
@tzneal tzneal deleted the remove-grace-period-on-deletion branch April 17, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants