Make script path dynamic and related to the page path #1472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…either release version or preview
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: c3513a0 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62228d9ae7f13e0007ec19ae 😎 Browse the preview: https://deploy-preview-1472--karpenter-docs-prod.netlify.app |
spring1843
changed the title
ellistarn
reviewed
Mar 4, 2022
| @@ -1,3 +1,5 @@ | |||
| {{ $file := .Get "file" | readFile }} | |||
| {{ $file := .Get "file" }} | |||
There was a problem hiding this comment.
Cool! Can we call this file version.html?
There was a problem hiding this comment.
The name of the files corresponds to the shortcode tag, e.g. {{% script file="... so if we change the name of the file we will have to use {{% version which would be a bit confusing.
ellistarn
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…either release version or preview
1. Issue, if available:
2. Description of changes:
This will change the behavior where the scripts are being read from the
previewdirectory, and instead use the release directory that comes from the path of the page, for example for the preview version it will read from./website/content/en/preview/...and for v0.6.4 it will read from./website/content/en/v0.6.4/....This allows us to manage the scripts of each version independently should we need to.
3. How was this change tested?
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.