remove the expect enqueued for eviction tests #1469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pods can enter/exit the eviction queue rapidly so looking for them in the queue itself is flaky. Instead, just check if they've been evicted. Fixes aws#706
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 99f940c 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62224894a626af0007c34c97 😎 Browse the preview: https://deploy-preview-1469--karpenter-docs-prod.netlify.app |
ellistarn
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
Fixes #706
2. Description of changes:
Pods can enter/exit the eviction queue rapidly so looking for
them in the queue itself is flaky. Instead, just check if they've
been evicted.
3. How was this change tested?
Unit tests
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.