Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redo refactor guides #1456

Merged
merged 5 commits into from
Mar 2, 2022
Merged

redo refactor guides #1456

merged 5 commits into from
Mar 2, 2022

Conversation

geoffcline
Copy link
Contributor

1. Issue, if available:
redo of #1428

2. Description of changes:
refactor getting started guides to have a parent guide directory

3. How was this change tested?
netlify preview

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Mar 2, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: d50445a

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/621fcd1225ff680007cf86da

😎 Browse the preview: https://deploy-preview-1456--karpenter-docs-prod.netlify.app

@geoffcline geoffcline enabled auto-merge (squash) March 2, 2022 19:53
Copy link
Contributor

@ellistarn ellistarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one minor comment and then good to go

@spring1843 spring1843 self-requested a review March 2, 2022 21:28
Copy link
Contributor

@spring1843 spring1843 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffcline geoffcline merged commit db7ed9c into aws:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants