Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webhook cert update issue if resource name differs from Helm chart #1367

Merged
merged 1 commit into from
Feb 17, 2022

Conversation

Swalloow
Copy link
Contributor

@Swalloow Swalloow commented Feb 17, 2022

1. Issue, if available:
When installing with custom release name, webhook cannot be created. #1359

2. Description of changes:
remove the hardcoded resourceName and make it {{ include "karpenter.fullname" . }}-cert
same as secrets

3. How was this change tested?

helm install . --generate-name --namespace kube-system --version 0.6.3 --dry-run --debug

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 17, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 1f8ba8d

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/620e6bd2979ec0000763bc5c

@bwagner5 bwagner5 self-requested a review February 17, 2022 15:48
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@suket22 suket22 merged commit 17b06f8 into aws:main Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants