Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct broken links to rbac.yaml for v0.6.1 #1305

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Correct broken links to rbac.yaml for v0.6.1 #1305

merged 1 commit into from
Feb 9, 2022

Conversation

spring1843
Copy link
Contributor

1. Issue, if available:

2. Description of changes:
Replaces the link to non-existent rbac.yaml into the four files it is broken down to after #1145

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for karpenter-docs-prod ready!

🔨 Explore the source changes: c77593d

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62042f7af7ee180007c0418c

😎 Browse the preview: https://deploy-preview-1305--karpenter-docs-prod.netlify.app

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to create permalinks rather than linking to main HEAD.

I was hoping we could template out the permalinks in the release process, but since it uses the commit hash of the tag rather than the actual tag... that may be more effort than it's worth.

@spring1843
Copy link
Contributor Author

need to create permalinks rather than linking to main HEAD.

I was hoping we could template out the permalinks in the release process, but since it uses the commit hash of the tag rather than the actual tag... that may be more effort than it's worth.

Let's do that as a follow up effort, created an issue to track that here: #1310

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bwagner5 bwagner5 merged commit 5ddf71b into aws:main Feb 9, 2022
@spring1843 spring1843 deleted the rm/correct-rbac-links-for-v0.6.1 branch February 12, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants