Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hugo to go toolchain #1260

Merged
merged 1 commit into from
Feb 2, 2022
Merged

Added hugo to go toolchain #1260

merged 1 commit into from
Feb 2, 2022

Conversation

ellistarn
Copy link
Contributor

1. Issue, if available:

2. Description of changes:
Dependency in a language other than go? 🙅

3. How was this change tested?

4. Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: link to issue
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify
Copy link

netlify bot commented Feb 2, 2022

✔️ Deploy Preview for karpenter-docs-prod canceled.

🔨 Explore the source changes: 38ebebb

🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/61faef6da9bdb90008b08325

@njtran
Copy link
Contributor

njtran commented Feb 2, 2022

AFAIK, Hugo is only used for creating releases. While small, I'm don't think we should add in tools that aren't necessary for the everyone into the toolchain, since it adds another method of tool installation failure. WDYT?

@geoffcline
Copy link
Contributor

I think this is the incorrect version of Hugo. we need Hugo-extended for the docsy theme.

I am unfamiliar with how go installs Hugo, so maybe it defaults to extended?

appreciate the gitingore updates

@ellistarn
Copy link
Contributor Author

I think this is the incorrect version of Hugo. we need Hugo-extended for the docsy theme.

I am unfamiliar with how go installs Hugo, so maybe it defaults to extended?

appreciate the gitingore updates

I found it was nice to use the same packaging mechanism for all our dependencies. e.g. brew only works on macs, and not always for the new M1s. I'm using the latest version here: https://github.com/gohugoio/hugo

@geoffcline
Copy link
Contributor

I tested it, go install github.com/gohugoio/[email protected] installs hugo v0.92.1 linux/amd64 BuildDate=unknown

We need hugo v0.92.0+extended linux/amd64 BuildDate=unknown

See: https://www.docsy.dev/docs/getting-started/#install-hugo

@geoffcline
Copy link
Contributor

excellent!

@ellistarn ellistarn merged commit 7713370 into aws:main Feb 2, 2022
@ellistarn ellistarn deleted the hugo branch March 4, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants