new task for config pod density #1237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for karpenter-docs-prod ready! 🔨 Explore the source changes: 1386165 🔍 Inspect the deploy log: https://app.netlify.com/sites/karpenter-docs-prod/deploys/62183e30f3c6550008d6021b 😎 Browse the preview: https://deploy-preview-1237--karpenter-docs-prod.netlify.app |
mikesir87
reviewed
Jan 28, 2022
|
Thanks for this detailed review @mikesir87 I understand it better now :) |
ellistarn
reviewed
Feb 25, 2022
| @@ -0,0 +1,59 @@ | |||
| --- | |||
| title: "Control Pod Density" | |||
There was a problem hiding this comment.
Suggested change
| title: "Control Pod Density" | |
| title: "Pod Density" |
There was a problem hiding this comment.
Control sends the wrong message, I think. Ultimately karpenter is going to have the say here. Limit might be more accurate, but I'd probably just drop any verb from the title.
There was a problem hiding this comment.
I think of pages under the task section fitting into a "I want to X" pattern. perhaps control is implied?
ellistarn
approved these changes
Feb 25, 2022
This was referenced Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Issue, if available:
#1216
2. Description of changes:
add task for configuring pod density
3. How was this change tested?
n/a
4. Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.